feat(web): add opt-in chat centering beside thread details - #29214

Approvability

Verdict: Approved at e4c9f3a

Macroscope's review found this PR approvable — Centers the timeline and composer beside an open thread-details card while retaining existing spacing constraints. The change is limited to visual layout, with no persistent-data or external-system effects.

^{You can add or adjust custom eligibility rules. Learn more.}

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: a7779fc
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 819cfc9d-8f87-49c8-b4b4-85eb284576ee

Commits

Reviewing files that changed from the base of the PR and between 5dfe62e and ded6a34.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

Merge Risk: Minimal · previous review 5dfe6

This adds an opt-in appearance setting for chat centering beside the details card. It is off by default, so existing layout behavior is preserved. No actionable merge-blocking risk was found.

Pre-merge checks: 3 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Linked Issues check		Issue #29081 asks for timeline and composer centering in the free space beside the sidebar and an open details card. Its Expected behavior does not mention an opt-in. The raw summary shows the centeri…	Maintainer confirmation is needed that an opt-in, default-off setting satisfies #29081. If the issue must be satisfied by default, the default value of centerChatBesideDetails in packages/contracts/src/settings.ts and the matching `Clie…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title "feat(web): add opt-in chat centering beside thread details" matches the main change. The PR adds an Appearance setting, defaulting to off, that centers chat beside an open thread details ca…
Out of Scope Changes check		The changed files support one feature: the opt-in centerChatBesideDetails client setting. The contracts files add the schema field, the patch field, and default and encoding tests. `resolveChatCanva…
Description check		The description follows the repository template. It has Problem, Change, Scope, and Verification sections, and it states the problem (#29081), the opt-in setting and its default-off behavior, the scop…

Full details: Title check

Explanation

The title "feat(web): add opt-in chat centering beside thread details" matches the main change. The PR adds an Appearance setting, defaulting to off, that centers chat beside an open thread details card. The changed files (chatCanvasLayout.ts, canvasStore.ts, ChatView.tsx, AppearanceSettingsPanel.tsx, settings contracts) all serve this feature. The title is a conventional commit in plain language and fits the repository's guidance.

Full details: Out of Scope Changes check

Explanation

The changed files support one feature: the opt-in centerChatBesideDetails client setting. The contracts files add the schema field, the patch field, and default and encoding tests. resolveChatCanvasLayout, resolveChatCanvasModel, and ChatCanvas use the setting for centering. ChatView passes the value through. The appearance panel, reset logic, and settings search entry expose the setting. These changes match the persistence, reset, and search behavior named in the PR description. Tests cover the new behavior. No unrelated product behavior appears in the summary.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope, and Verification sections, and it states the problem (#29081), the opt-in setting and its default-off behavior, the scope (a feature tied to #29081 and a link to the request for both alignments), and detailed verification. The Verification section gives test counts, real-client measurements (x=382 to x=236 at 1500px), and before/after screenshots, and it names what was not exercised (native Electron, mobile, relay/tunnel). Two template points are weak. First, the template says to accept bug fixes, not features, and this PR is an opt-in feature. The Scope section acknowledges this and cites a maintainer request, but the link to that request is a PR comment, not a maintainer-approved issue. Second, the template asks for the model and harness used, and the description states 'Created with gpt-6.1-sol via Codex/T3 Code' at the end, which satisfies that point. The description is long and relies on external evidence links, but the required content is present.

Full details: Linked Issues check

Explanation

Issue #29081 asks for timeline and composer centering in the free space beside the sidebar and an open details card. Its Expected behavior does not mention an opt-in. The raw summary shows the centering logic is implemented. In resolveChatCanvasLayout, when centerChatBesideDetails is true and a details card exists, the chat centers on the card's left edge. Otherwise the container width is used. Tests cover this path. The current PR description and objectives state that the setting defaults to false. With the default, the reviewed head keeps the existing centering, so the issue's expected behavior is not the default. The PR author and the discussion (#34108, PR comment 6782473529) frame opt-in as the intended resolution. The previous PASS assessed a default-on change and no longer applies. Whether an opt-in setting satisfies #29081 is a product decision not established by the issue text or the code. The opt-in centering path is verified by the summary and test descriptions. The raw summary does not show the actual layout code, so this conclusion rests on summaries and the PR description.

Resolution

Maintainer confirmation is needed that an opt-in, default-off setting satisfies #29081. If the issue must be satisfied by default, the default value of centerChatBesideDetails in packages/contracts/src/settings.ts and the matching ClientSettingsSchema default would need to change to true, and the default-layout tests would need to be updated. Alternatively, the PR should state that it partially addresses #29081.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Verified in a real dev environment

verified head e4c9f3a534c9d9bd77f6f072ec85692146947cce as-is on a linux boat vm, using the repository's playwright and /usr/bin/google-chrome against real background dev servers, one at a time.

• reproduced on github/main (8648aea3db): at 1675px viewport width, chat centered at x=965.5 instead of the midpoint beside details, x=819.5.
• created a project pointing at a real git repository through the app. ran real codex gpt-6.1-sol turns through the composer on main and the pr head. the pr turn read the repository and completed successfully.
• reused the app-created conversation for matching before/after captures. on the pr, both timeline and composer center at x=819.5. closing details restores x=965.5; reopening restores x=819.5.
• checked 1300px tight inline layout: the chat lane ends at x=976, preserving 32px before the card at x=1008. at 1200px, details opens as a popover and chat returns to the full-canvas center. widening restores inline layout.
• blacksmith passed all 25 focused layout/model tests and vp run check:changed 47f2c8d29e981c7723467efe137ee19e91df924e (format, lint, knip, affected typechecks, layout tests, react compiler coverage). no code changes were needed.

Not verified

native desktop shell, ios/android clients, other providers, and remote/relay connections were not exercised. this pass used the local web client and real codex provider through the vm's proxy. uploaded video playback and seeking were checked in t3's browser.

Heads-up: this changes the same centering line as #34108, which asks for the opposite (keep the Comfortable-width chat centered in the window when the sidebar or details card opens). Could this land behind a setting so both behaviors stay available?